Skip to content

Improved German and fr-CH formatLong#553

Merged
kossnocorp merged 5 commits into
date-fns:masterfrom
vanvuongngo:fix-format-long
Sep 29, 2017
Merged

Improved German and fr-CH formatLong#553
kossnocorp merged 5 commits into
date-fns:masterfrom
vanvuongngo:fix-format-long

Conversation

@vanvuongngo
Copy link
Copy Markdown
Member

formatLong L for German and fr-CH

@leshakoss leshakoss self-requested a review September 8, 2017 13:21
Copy link
Copy Markdown
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

describe.skip should be ditched before merge.

@kossnocorp
Copy link
Copy Markdown
Member

kossnocorp commented Sep 18, 2017

Please tell me if you need help with the PR.

@vanvuongngo
Copy link
Copy Markdown
Member Author

@kossnocorp You can continue the PR. I do not know the actual alpha state.

@kossnocorp
Copy link
Copy Markdown
Member

@vanvuongngo what do you mean? I still see some describe.skip in the code. I would love to release a new alpha with your changes once it's done.

@vanvuongngo
Copy link
Copy Markdown
Member Author

@kossnocorp To remove the describe.skip it needs translations

@kossnocorp
Copy link
Copy Markdown
Member

I see. So you're have no plans to continue work on the PR?

I'm afraid that I can't continue working on it as I don't understand German. I can help only with code and guidance.

@vanvuongngo
Copy link
Copy Markdown
Member Author

@kossnocorp Glad to here you want to integrate my change. I had a look at the translation and removed the skips.

@kossnocorp kossnocorp merged commit f27f470 into date-fns:master Sep 29, 2017
@kossnocorp
Copy link
Copy Markdown
Member

Thank you a lot! It was released as v2.0.0-alpha.7. See change log: https://gist.github.com/kossnocorp/a307a464760b405bb78ef5020a4ab136#v200-alpha7

@vanvuongngo vanvuongngo deleted the fix-format-long branch September 29, 2017 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants