#810 Correct short and abbreviated dayValues for de locale#817
Merged
Conversation
leshakoss
requested changes
Jul 26, 2018
Member
leshakoss
left a comment
leshakoss
left a comment
There was a problem hiding this comment.
Great! Could you also please fix the test src/locale/de/test.js on line 87?
The values are taken from https://www.unicode.org/cldr/charts/32/summary/de.html#1844, using "Days - (abbreviated|short) - Formatting". Alternatively, the short values could be left as is (without the period). According to the CLDR table, that's the Swiss locale, but it would provide a two-letter version matching the English locale.
Contributor
Author
|
Done |
Member
|
I've changed the short values to be without the period, and released this as v2.0.0-alpha.14. Thank you for your contribution! ⭐️ |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values are taken from https://www.unicode.org/cldr/charts/32/summary/de.html#1844, using "Days - (abbreviated|short) - Formatting".
Alternatively, the short values could be left as is (without the period). According to the CLDR table, that's the Swiss locale, but it would provide a two-letter version matching the English locale.