Update VI locale for v2#846
Conversation
kossnocorp
left a comment
kossnocorp
left a comment
There was a problem hiding this comment.
The code looks good to me. @leshakoss please take a look.
@lihop please remove vi from the outdated languages list: https://github.com/date-fns/date-fns/blob/master/outdatedLocales.json#L32
|
|
||
| // Vietnammese locale reference: http://www.localeplanet.com/icu/vi-VN/index.html | ||
| // Capitalization reference: http://hcmup.edu.vn/index.php?option=com_content&view=article&id=4106%3Avit-hoa-trong-vn-bn-hanh-chinh&catid=2345%3Atham-kho&Itemid=4103&lang=vi&site=134 | ||
| var weekdayValues = { |
There was a problem hiding this comment.
@lihop aren't these references are still actual and worth keeping?
There was a problem hiding this comment.
Yes. I will add them back in.
…' usage; Update tests to pass new format
Enhance parser for quarter "quý IV";
lihop
force-pushed
the
update-locale-vi
branch
from
791da54 to
4a24e6d
Compare
|
I have removed vi from the outdated languages list and re-added the locale references. |
|
Kudos to you, guys! I'm going to merge few more pending locales and publish a release. Stay tuned! |
|
I've just published a new version with this locale Thank you again for your work! |
5 participants
Closes #828