bugfix: fixed skewed range in put_data of Storage#110
Merged
Conversation
ensure! macro was mutating the range so by the end of the macro evaluation the range was in wrong state
Member
|
Wow, great find @khodzha! I can confirm that this fixes the |
Member
|
I fixed and rebased the put test in #111, which I think should also be a fine test for this (so the box above can be ticket IMO). |
bltavares
added a commit
to bltavares/hypercore
that referenced
this pull request
May 4, 2020
Member
|
I'm trying to test on my local prototype, but I'm not finding the correct combination of forks between hypercore, bitfield-rle and this branch that compiles yet. I'll try again on the weekend, but it looks like a good changeset in combination with the tests of #111 @Frando If you want, I could try to do a octopus merge of both and run locally the tests to merge both on master. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug fix:
ensure!macro was mutating the range so by the end of the macro evaluationthe range was in wrong state
Checklist
Context
this fixes test in #108 if my comment in that PR is addressed
Semver Changes
no changes? idk 🤷♂️