Compress bitfield and expose it to network code#96
Merged
Conversation
bltavares
force-pushed
the
bitfield-compress
branch
from
67b14c9 to
1c0e69a
Compare
9 tasks
yoshuawuyts
reviewed
Mar 2, 2020
| // TODO: use the index to speed this up *a lot* | ||
| /// https://github.com/mafintosh/hypercore/blob/06f3a1f573cb74ee8cfab2742455318fbf7cc3a2/lib/bitfield.js#L111-L126 | ||
| pub fn compress(&self, start: usize, length: usize) -> std::io::Result<Vec<u8>> { | ||
| if start == 0 && length == 0 { |
Contributor
There was a problem hiding this comment.
A comment here could be useful?
new dalek pre version has some changes, and requires a new rand version. This commit bumps both, including changes needed on quickcheck to use new rand.
The network code requires to send compressed bitfields to the wire with the size of the feed. This commit exposes the bitfield as a public method, and adds the compress method. bitfield_rle is not encoding the same as node's version. Tests are broken because of that.
bltavares
force-pushed
the
bitfield-compress
branch
from
58d8c25 to
9c6812d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network code requires to send compressed bitfields to the wire with the size of the feed.
This commit exposes the bitfield as a public method, and adds the compress method.
bitfield_rle is not encoding the same as node's version.
Tests are broken because of that.
This is a draft while working on other codes, so I can pull from other machines. After that, I will cleanup the changes to have it easier to review, depending on less PRs.
Choose one: a 🙋 feature
Checklist
Context
Semver Changes
minor