Implement async API for random-access-storage#22
Merged
Conversation
This commit moves the API from a sync call into async functions using async_trait. We would like to use async operations on hypercore, and it would be nice to have the underlying storage using async-io when possible. As discussed on datrs/hypercore#97, we could change the API to use async functions on the 'ram' trait. Async Trait methods are still unstable, but possible using the 'async-trait' crate through a macro. This PR moves the API to use async-fns. Tests are passing.
This was referenced Feb 26, 2020
Member
Author
|
@substack FYI this would impact |
yoshuawuyts
reviewed
Mar 2, 2020
|
|
||
| [dependencies] | ||
| async-trait = "0.1.24" | ||
| futures = "0.3.4" |
Contributor
There was a problem hiding this comment.
Compile times are generally better if only including futures-io for the AsyncRead + AsyncWrite traits. Alternatively async-std provides a core flag iirc.
yoshuawuyts
approved these changes
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the API from a sync call into async functions using async_trait.
We would like to use async operations on hypercore, and it would be nice to have the underlying storage using async-io when possible.
As discussed on datrs/hypercore#97, we could change the API to use async functions on the 'ram' trait.
Async Trait methods are still unstable, but possible using the 'async-trait' crate through a macro.
This PR moves the API to use async-fns. Tests are passing.
Choose one: a 🙋 feature
Checklist
Context
Semver Changes
major as this is a breaking change and we are above 1.0.0