Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: davidstump/SwiftPhoenixClient
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.9.1
Choose a base ref
...
head repository: davidstump/SwiftPhoenixClient
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.9.2
Choose a head ref
  • 5 commits
  • 19 files changed
  • 3 contributors

Commits on Aug 30, 2018

  1. Strong memory cycle fixes (#111)

    * Fix Socket <-> PhxTimer strong reference cycle
    
    * Fix Channel strong reference cycles
    
    * Fix Socket <-> Channel reference cycle
    
    * Update CHANGELOG.md
    darrenclark authored and dsrees committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    e300027 View commit details
    Browse the repository at this point in the history
  2. Fixes leak and Socket.disconnect() not calling onClose (#112)

    * Fix Socket.disconnect not calling onClose
    
    Since connection.delegate is nil'd out, the Socket wasn't getting the
    `websocketDidDisconnect(socket:error:)` delegate message so it'd never
    call onClose callbacks.
    
    This also fixes an issue where the Socket would never be deinit'd
    because the current run loop had a strong reference to it (via the
    heartbeatTimer)
    
    * Stop timer & fire onClose directly
    
    instead of relying on the `onConnectionClosed()` function.
    `onConnectionClosed()` does some additional things that we don't want
    (i.e. starting the reconnect timer) to happen when a Socket is
    explicitly disconnected.
    
    * Add tests for disconnect() calling onClose
    darrenclark authored and dsrees committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    ade5c27 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2018

  1. Configuration menu
    Copy the full SHA
    dd78d3e View commit details
    Browse the repository at this point in the history
  2. Remove Copy Phase from project, resolving Carthage issues (#114)

    * Removed copy frameworks for carthage
    
    * Update example project
    dsrees authored Sep 9, 2018
    Configuration menu
    Copy the full SHA
    bcac45e View commit details
    Browse the repository at this point in the history
  3. Prepareing version 0.9.2

    Daniel Rees committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    155bc26 View commit details
    Browse the repository at this point in the history
Loading