Merged
Conversation
dsrees
approved these changes
Aug 30, 2018
Collaborator
dsrees
left a comment
dsrees
left a comment
There was a problem hiding this comment.
This looks good. Thanks for the fix!
| }) | ||
|
|
||
| it("should not introduce any retain cycles", closure: { | ||
| weak var channel = Channel(topic: "topic", params: ["one": 2], socket: mockSocket) |
Collaborator
There was a problem hiding this comment.
👍 thank you for not only fixing the issue but also providing test cases with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109
Fixes strong reference cycles by using
weak, following these "rules":SocketownsChannels (withChannelhaving a weak reference back toSocket)ChannelownsPushes (withPushhaving a weak reference back toChannel)Socket/ChannelownPhxTimers, usedweakin callback blocks to break the strong reference cycleSocket/Channelnow alsoreset()their timers indeinit