#34 - Presence#119
Merged
dsrees merged 3 commits intodavidstump:masterfrom Oct 17, 2018
simpers:master
Merged
Conversation
Collaborator
|
Thanks @simpers. I'll get this merged in and try to add more tests soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick little implementation to get the bare stuff working. Ported Phoenix's JS version as much as I could. Added some tests but could use a lot more of them, but they're very tedious to write and I don't have too much time at the moment. Have tried it in our consumer app and it seems to do what it is supposed to be doing.