Merged
Conversation
Closed
Collaborator
|
@jklp could you please update your branch with master. I've removed jazzy as a gem |
Contributor
Author
|
Cool I've just pulled from master and rebased - let me know if need anything else 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have only added the tvOS target and not the tests, as
throws if attempting to join multiple timesruns into afatalError(), which is anEXC_BAD_INSTRUCTIONwhich doesn't seem to be caught on tvOS (sorry I'm not 100% across why this).I went back further in the history (0.6.x) to see how it was handled previously and noticed that there weren't any tests for tvOS either so not sure if you came across this problem previously too?