Merged
Conversation
Collaborator
|
Looks good. I'm gonna check it out, test it and publish over the weekend :) thanks man! |
Contributor
Author
|
Excellent, this was fun! I noticed settings are loaded only once, meaning updates to the settings file require users to run |
Collaborator
|
Please do :)) go for it!
On Fri, Dec 16, 2016 at 9:21 AM +0100, "Kristoffer Östlund" <notifications@github.com> wrote:
Excellent, this was fun! I noticed settings are loaded only once, meaning updates to the settings file require users to run Reload Window or restart the application. I might have a stab at that too if you don't mind?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
To keep PRs small I made another PR for keeping configuration up-to-date #15 |
Contributor
Author
|
@jakob101 Any status on this? Anything I can do? |
Collaborator
|
Hey Kristoffer,
Didn't make it before vacation, and now I'm abroad until mid next week. This is on top of my to do list when I come back. Sorry for the delay.
On Fri, Dec 30, 2016 at 10:18 AM +0100, "Kristoffer Östlund" <notifications@github.com> wrote:
@jakob101 Any status on this? Anything I can do?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
Super, enjoy your vacation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for excluding extensions specified in the settings file. By default
.jsexcluded.Extensions in the list are case insensitive, and including the dot is optional. In the below example, files ending with
.jsand.jsxare excluded, but all other extensions are left in.Edit: This closes #13
{ "relativePath.removeLeadingDot": true, "relativePath.ignore": [ "**/node_modules/**", "**/*.dll", "**/obj/**", "**/objd/**", "**/dist/**" ], "relativePath.removeExtension": false, "relativePath.excludedExtensions": [ "js", ".JSX" ] }