Merged
Conversation
1. Upgrade to vscode 1.1.10 to get the `getWorkspaceFolder` api 2. On change of tab refresh the files cache if workspace folder changes 3. Show info message when using plugin when workspacePath is null
jakob101
requested changes
Dec 19, 2017
src/extension.ts
Outdated
| // Watch for file system changes - as we're caching the searched files | ||
| this._watcher = workspace.createFileSystemWatcher("**/*.*", false, true, false); | ||
|
|
||
| // this._watcher.onDidChange() |
|
|
||
| // on change active text editor refresh the cache | ||
| // if the workspace folder has changed | ||
| window.onDidChangeActiveTextEditor((e: TextEditor) => { |
Collaborator
There was a problem hiding this comment.
How often does this happen? On every open/view of a file?
Collaborator
|
Looks okay to me, please remove the comment and we're good to go! |
|
@rrag are you still interested in finishing this? |
Contributor
Author
|
Sorry for the delay, I forgot about this. I am pushing up the change in a min |
Contributor
Author
|
Done. @jakob101 sorry for the delay again. Please review and merge |
Collaborator
|
No worries. Thanks! 👍 👍 |
|
Can this be published as a new version, or is it still being tested? |
Collaborator
|
I’ll publish after verification on Sunday, guys :)
…________________________________
From: Brandon Nicholls <notifications@github.com>
Sent: Friday, January 26, 2018 10:32:03 PM
To: jakob101/RelativePath
Cc: Jakob Werner; State change
Subject: Re: [jakob101/RelativePath] Support multi-root workspace (#22)
Can this be published as a new version, or is it still being tested?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#22 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA-v2uxXe_f_TsnaCmBKFyd5TjgSiF-Cks5tOkRTgaJpZM4REuv6>.
|
Collaborator
|
Done! Thanks folks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getWorkspaceFolderapi