Skip to content

Added support for extending limit for quick filter through configuration #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakob101 merged 4 commits into from
Apr 22, 2018
Merged

Added support for extending limit for quick filter through configuration #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50dbeb4
Added support for extending limit for quick filter through configuration
Apr 14, 2018
eea7d2e
Update extension.ts
sivcan Apr 17, 2018
5e9c3c5
package.json change
Apr 22, 2018
3ad2b60
Version change
Apr 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "RelativePath",
"description": "Get relative url paths from files in the current workspace.",
"version": "1.3.0",
"version": "1.4.0",
"repository": {
"type": "git",
"url": "https://github.com/jakob101/RelativePath"
Expand Down
12 changes: 11 additions & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,18 @@ class RelativePath {
return;
}

let extendedLimit = this._configuration.extendedLimit,
disableQuickFilter = true;

if (extendedLimit && this._items.length <= extendedLimit) {
disableQuickFilter = false;
}
else if (this._items.length <= 1000) {
disableQuickFilter = false;
}

// Don't filter on too many files. Show the input search box instead
if (this._items.length > 1000) {
if (disableQuickFilter) {
const placeHolder = `Found ${this._items.length} files. Enter the filter query. Consider adding more 'relativePath.ignore' settings.`;
const input = window.showInputBox({placeHolder});
input.then(val => {
Expand Down