Rename app to TritonAI Harness#20
Closed
dbalders wants to merge 6 commits into
Closed
Conversation
📝 WalkthroughWalkthroughAll occurrences of "T3 Code" and "TritonAI Code" are renamed to "TritonAI Harness" across desktop, web, mobile, server, relay infrastructure, build scripts, and documentation. Two changes carry observable behavior: ChangesProduct Rename: "TritonAI Code" / "T3 Code" → "TritonAI Harness"
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
vouch:trusted
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dbalders
force-pushed
the
tritonai-harness-branding
branch
from
June 21, 2026 18:33
59fdc87 to
4aad4fe
Compare
dbalders
marked this pull request as ready for review
June 21, 2026 18:39
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/desktop/src/app/DesktopAppIdentity.test.ts (1)
108-108: 🧹 Nitpick | 🔵 Trivial | 💤 Low valueConsider aligning the default
legacyPathNeedlewith the production legacy name.The default needle
"T3 Code"(Line 127) differs from the actual productionlegacyUserDataDirNameof"TritonAI Code"(set in DesktopEnvironment.ts Line 166). While the current tests explicitly pass the correct needle and don't rely on this default, the mismatch could confuse future maintainers.Consider either:
- Changing the default to
"TritonAI Code"to match production, or- Removing the default fallback (use
nullorundefined) to make the test more explicit♻️ Option 1: Align with production legacy name
exists: (path) => Effect.succeed( input.legacyPathExists === true && - path.includes(input.legacyPathNeedle ?? "T3 Code"), + path.includes(input.legacyPathNeedle ?? "TritonAI Code"), ),♻️ Option 2: Make the parameter required when legacyPathExists is true
exists: (path) => Effect.succeed( - input.legacyPathExists === true && - path.includes(input.legacyPathNeedle ?? "T3 Code"), + input.legacyPathExists === true && + input.legacyPathNeedle !== undefined && + path.includes(input.legacyPathNeedle), ),Also applies to: 125-128
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/desktop/src/app/DesktopAppIdentity.test.ts` at line 108, The default value for the `legacyPathNeedle` property in the test fixture does not align with the production legacy name used in DesktopEnvironment.ts. Update the default value of `legacyPathNeedle` from "T3 Code" to "TritonAI Code" to match the actual production `legacyUserDataDirName` value, ensuring consistency between test setup and production code and reducing confusion for future maintainers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/desktop/src/app/DesktopAppIdentity.test.ts`:
- Line 108: The default value for the `legacyPathNeedle` property in the test
fixture does not align with the production legacy name used in
DesktopEnvironment.ts. Update the default value of `legacyPathNeedle` from "T3
Code" to "TritonAI Code" to match the actual production `legacyUserDataDirName`
value, ensuring consistency between test setup and production code and reducing
confusion for future maintainers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0a70cec8-c7bd-43f0-b7ad-72ca9c8b15b1
📒 Files selected for processing (115)
.github/workflows/release.ymlREADME.mdapps/desktop/package.jsonapps/desktop/scripts/electron-launcher.mjsapps/desktop/src/app/DesktopApp.tsapps/desktop/src/app/DesktopAppIdentity.test.tsapps/desktop/src/app/DesktopEnvironment.test.tsapps/desktop/src/app/DesktopEnvironment.tsapps/desktop/src/electron/ElectronApp.test.tsapps/desktop/src/ssh/DesktopSshPasswordPrompts.tsapps/desktop/src/window/DesktopApplicationMenu.test.tsapps/desktop/src/window/DesktopApplicationMenu.tsapps/marketing/src/layouts/Layout.astroapps/marketing/src/pages/download.astroapps/marketing/src/pages/index.astroapps/mobile/README.mdapps/mobile/app.config.tsapps/mobile/modules/t3-composer-editor/ios/T3ComposerEditor.podspecapps/mobile/modules/t3-markdown-text/T3MarkdownText.podspecapps/mobile/modules/t3-markdown-text/UPSTREAM.mdapps/mobile/modules/t3-review-diff/T3ReviewDiffNative.podspecapps/mobile/modules/t3-terminal/T3TerminalNative.podspecapps/mobile/src/app/index.tsxapps/mobile/src/app/settings/index.tsxapps/mobile/src/components/BrandMark.tsxapps/mobile/src/features/cloud/linkEnvironment.test.tsapps/mobile/src/lib/authClientMetadata.tsapps/mobile/src/lib/connection.test.tsapps/mobile/src/lib/repositoryGroups.test.tsapps/mobile/src/widgets/AgentActivity.test.tsapps/server/src/auth/utils.test.tsapps/server/src/bin.tsapps/server/src/cli/server.tsapps/server/src/mcp/McpHttpServer.tsapps/server/src/provider/CodexDeveloperInstructions.tsapps/server/src/provider/Layers/ClaudeProvider.tsapps/server/src/provider/Layers/CodexProvider.tsapps/server/src/provider/Layers/CursorProvider.tsapps/server/src/provider/Layers/GrokProvider.tsapps/server/src/provider/Layers/OpenCodeAdapter.tsapps/server/src/provider/Layers/OpenCodeExternalSessionSync.test.tsapps/server/src/provider/Layers/OpenCodeExternalSessionSync.tsapps/server/src/provider/Layers/OpenCodeProvider.tsapps/server/src/provider/Layers/ProviderRegistry.test.tsapps/server/src/provider/Layers/ProviderService.tsapps/server/src/provider/acp/GrokAcpSupport.test.tsapps/server/src/provider/providerMaintenanceRunner.tsapps/server/src/provider/providerStatusCache.test.tsapps/server/src/relay/AgentAwarenessRelay.test.tsapps/server/src/server.test.tsapps/server/src/serverRuntimeStartup.tsapps/server/src/startupAccess.tsapps/server/src/textGeneration/OpenCodeTextGeneration.tsapps/server/src/vcs/GitVcsDriver.tsapps/web/index.htmlapps/web/src/authBootstrap.test.tsapps/web/src/branding.test.tsapps/web/src/branding.tsapps/web/src/cloud/linkEnvironment.tsapps/web/src/components/ChatView.browser.tsxapps/web/src/components/RightPanelTabs.tsxapps/web/src/components/SplashScreen.tsxapps/web/src/components/clerk/DesktopClerkSignIn.tsxapps/web/src/components/cloud/RelayClientInstallDialog.tsxapps/web/src/components/desktop/SshPasswordPromptDialog.tsxapps/web/src/components/desktopUpdate.logic.test.tsapps/web/src/components/desktopUpdate.logic.tsapps/web/src/components/preview/PreviewPanel.tsxapps/web/src/components/settings/ConnectionsSettings.tsxapps/web/src/components/settings/KeybindingsSettings.tsxapps/web/src/components/settings/SettingsPanels.browser.tsxapps/web/src/components/settings/SettingsPanels.tsxapps/web/src/components/settings/providerStatus.tsapps/web/src/firstRunOnboarding.test.tsapps/web/src/routes/_chat.tsxapps/web/src/tritonAiWorkspace.tsapps/web/src/versionSkew.test.tsapps/web/src/versionSkew.tsdocs/architecture/overview.mddocs/architecture/remote.mddocs/architecture/runtime-modes.mddocs/cloud/t3-code-connect-auth-flow.htmldocs/getting-started/codex-prerequisites.mddocs/integrations/source-control-providers.mddocs/operations/observability.mddocs/providers/claude.mddocs/providers/codex.mddocs/reference/encyclopedia.mddocs/user/keybindings.mddocs/user/remote-access.mdinfra/relay/README.mdinfra/relay/scripts/deploy.tsinfra/relay/src/agentActivity/AgentActivityPublisher.tsinfra/relay/src/agentActivity/ApnsClient.test.tsinfra/relay/src/agentActivity/ApnsDeliveries.test.tsinfra/relay/src/agentActivity/LiveActivities.test.tsinfra/relay/src/agentActivity/MobileRegistrations.test.tsinfra/relay/src/agentActivity/apnsDeliveryJobs.test.tsinfra/relay/src/observability.tsinfra/skills-catalog/README.mdpackages/client-runtime/src/remote.test.tspackages/client-runtime/src/threadDetailReducer.test.tspackages/contracts/src/relay.tspackages/contracts/src/settings.tspackages/shared/src/relayClient.tspackages/ssh/src/auth.tsscripts/build-desktop-artifact.test.tsscripts/build-desktop-artifact.tsscripts/dev-runner.tsscripts/merge-update-manifests.test.tsscripts/notify-discord-release.test.tsscripts/notify-discord-release.tsscripts/release-smoke.tsscripts/resolve-nightly-release.test.tsscripts/resolve-nightly-release.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
vp check(passes; existing nested-component warnings remain)vp run typecheckvp run --filter @t3tools/web buildASTRO_TELEMETRY_DISABLED=1 vp run --filter @t3tools/marketing buildorigin/tritongptNote: repo-wide
vp teststill hits the existing Vitest/Vite suite-collection runner issue observed before this PR.Summary by CodeRabbit