Added new Bootstrap version to three examples#1870
Closed
kleczekr wants to merge 8 commits into
Closed
Conversation
…ute the file when all the examples are checked) for three examples
…ion---LIBRARY CHANGE
5 tasks
Collaborator
|
A few of the test cases were failing, I have updated the CSS class name in the test cases, and now all test cases pass. Other than that I have reordered and squashed commits into fewer commits. |
Collaborator
|
Please check the last few commits in dc-v5 branch - https://github.com/dc-js/dc.js/commits/dc-v5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new Bootstrap version to three examples (for now from a CDN) and fixed formatting issues in one of the examples caused by old classes.