fix: use TARGETARCH instead of TARGETPLATFORM in user Dockerfiles#6711
fix: use TARGETARCH instead of TARGETPLATFORM in user Dockerfiles#6711rfay merged 1 commit intoddev:masterfrom
Conversation
|
Can confirm in manual testing that this worked. |
|
Download the artifacts for this pull request:
See Testing a PR. |
|
@rfay, I also want to point out that At that time I checked sqlite3.45.1 - it worked, and I forgot about it until today.
ddev/containers/ddev-webserver/Dockerfile Lines 70 to 75 in 924ad6f It will add +1250 KBytes to the image:
Let me know what you think about it. |
|
Now that we sorted out what we were chasing, I think TARGETARCH might have been (He had an ancient Colima with an ancient docker server version in it, that apparently passed TARGETPLATFORM=linux/arm64/v8) As far as I can tell, TARGETPLATFORM in this context should only have been linux/amd64 or linux/arm64. That doesn't mean that this PR is less correct. It's more elegant for sure. |
rfay
left a comment
There was a problem hiding this comment.
I think we should go with this because it's simpler and more elegant.
The Issue
From Drupal Slack https://drupal.slack.com/archives/C5TQRQZRR/p1731341586120089
Looking at that URL, I suspect that the Docker build engine is using
arm64/v8as the target platform, which makes sense, but that maybe makes the URL of the SQLite.debwrong.If I remove the
/v8from that URL in my browser, it actually tries to download something.Is there a way I can override the
TARGETPLATFORMbuild argument in.ddev/config.yamlto force it to bearm64, as a workaround?From https://ddev.readthedocs.io/en/stable/users/extend/customizing-images/#adding-extra-dockerfiles-for-webimage-and-dbimage, it looks like maybe the workaround that installs SQLite should be using
TARGETARCHinstead ofTARGETPLATFORM.How This PR Solves The Issue
Uses
TARGETARCHin the user Dockerfile, this change is also important for the newly added 'install_php_extensions.sh'Manual Testing Instructions
Should pass the tests.
Automated Testing Overview
Release/Deployment Notes