Fix agent skill paths#2
Merged
Merged
Conversation
ElCuboNegro
added a commit
that referenced
this pull request
May 26, 2026
…-layer fix, TLS hardening Closes #334 — FM-01: CornerStone Server has no deployment artifact. ## What's in this squash ### Issue #334 / FM-01 — Lodge L0 onboarding - `cornerstone/domain/doctor.py` — adds `_check_server_reachability()` for `cornerstone doctor` (AC-2/AC-4/AC-5) - `cornerstone/domain/login.py` — adds `display_key_with_timeout()` and `get_api_key_securely()` (AC-1/AC-3), fixes inaccurate TODO comment - `services/cornerstone-server/` — reference docker-compose.yml + README for self-hosting Lodge (AC-6) - `proposed_architecture/lodge.mermaid` — internal architecture diagram for Lodge - `docs/cli_reference.md` — adds Lodge Server Commands and Self-Hosting sections - `tests/test_bootstrap_roundtrip.py` — 6 roundtrip tests covering doctor reachability and scaffold Lodge registration ### Import-linter fix (pre-existing from 6319427) - `.importlinter` — corrects layer order to `adapters > domain > ports` (domain→ports is intentional per ADR-0091 §Phase 1); adds `ignore_imports` for Phase 2 violations - All 5 import-linter contracts now KEPT ### Docs strict-mode fixes - `docs/cli_reference.md` — replace relative links to files outside docs/ with GitHub URLs - `docs/infra/gcp_deploy_design.md` — fix `../` prefix for paths from subdirectory ### Security hardening - `cornerstone/domain/doctor.py` — explicit `ctx.minimum_version = TLSVersion.TLSv1_2` (resolves CodeQL py/insecure-protocol / CWE-326) ## Acceptance Criteria verified - [x] AC-1: `display_key_with_timeout()` warns and auto-clears - [x] AC-2: `_check_server_reachability()` returns True on 200 - [x] AC-3: `get_api_key_securely()` uses masked input - [x] AC-4: Doctor returns False on unreachable server - [x] AC-5: Doctor is advisory-only when no server configured - [x] AC-6: `services/cornerstone-server/` provides docker-compose.yml ## Open items - CodeQL alert #2 (`login.py:36`): intentional FM-13 display — needs delegated review dismissal - CodeQL annotation on test_bootstrap_roundtrip.py:144: false positive (test assertion, not URL sanitization) - Phase 2 port injection for domain.scaffold/domain.rtk tracked in ADR-0091 §Phase 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
How Has This Been Tested?
Checklist
ruff check,ruff format).