Conversation
Instead of reading minecraft-data and transforming it at runtime, generate it in src/protocol/generate.js and write to .jsons in src/protocol. Ref PrismarineJS/node-minecraft-protocol#301
This allows removing the indirection in src/client/autoVersion - no need to lookup game version from protocol version only to have the client instance lookup the protocol version from the game version.
Owner
Author
|
Looks like this broke the server ping response somehow (didn't test during development), need to rebase on master, maybe rebuild incrementally to isolate the failure and/or smaller digestable changes to PR to nmp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to improve on some of the dynamic versioning code, ref PrismarineJS/node-minecraft-protocol#234 (comment)