Skip to content

fix(navbar): enable section navigation #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepdevjose merged 1 commit into from
Jul 1, 2025
Merged

fix(navbar): enable section navigation #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ <h1 class="name" title="Jose Cerón">José M. Cortes C.</h1>
<div class="main-content">
<nav class="navbar">
<ul class="navbar-list">
<li class="navbar-item"><button class="navbar-link" data-nav-link>About</button></li>
<li class="navbar-item"><button class="navbar-link" data-nav-link>Resume</button></li>
<li class="navbar-item"><button class="navbar-link" data-nav-link>Portfolio</button></li>
<li class="navbar-item"><button class="navbar-link" data-nav-link>Blog</button></li>
<li class="navbar-item"><button class="navbar-link" data-nav-link>Contact</button></li>
<li class="navbar-item"><button class="navbar-link" data-nav-link="about">About</button></li>
<li class="navbar-item"><button class="navbar-link" data-nav-link="resume">Resume</button></li>
<li class="navbar-item"><button class="navbar-link" data-nav-link="portfolio">Portfolio</button></li>
<li class="navbar-item"><button class="navbar-link" data-nav-link="blog">Blog</button></li>
<li class="navbar-item"><button class="navbar-link" data-nav-link="contact">Contact</button></li>
</ul>
</nav>

Expand Down
8 changes: 4 additions & 4 deletions js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,18 @@ document.addEventListener('DOMContentLoaded', () => {
link.addEventListener('click', e => {
e.preventDefault(); // cancel default link behavior
const target = link.dataset.navLink;
// show/hide secciones
// show/hide sections
pages.forEach(page => {
page.hidden = page.dataset.page !== target;
page.classList.toggle('active', page.dataset.page === target);
});
// active class
// active state for links
navLinks.forEach(n => n.classList.toggle('active', n === link));
});
});

// first page active
if (navLinks.length && pages.length) {
navLinks[0].classList.add('active');
pages.forEach((page, i) => page.hidden = i !== 0);
pages.forEach((page, i) => page.classList.toggle('active', i === 0));
}
});