fix: DH-21451: make Python packages: pytz and zoneinfo soft deps #7596
Conversation
jmao-denver
requested review from
chipkent,
cpwright and
rcaudy
as code owners
jmao-denver
added
python
NoDocumentationNeeded
python-server-side
NoReleaseNotesNeeded
No docs changes detected for db9e85c |
There was a problem hiding this comment.
Pull request overview
This PR converts the Python packages pytz and zoneinfo from hard dependencies to soft (optional) dependencies in the Deephaven time module. This allows the Deephaven server to function without requiring these timezone libraries, while still supporting them when available.
Changes:
- Wrapped
pytzandzoneinfoimports in try-except blocks to handle ImportError - Added conditional checks before using these libraries in timezone conversion logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jmao-denver
force-pushed
the
DH-21451-make-pytz-soft-dep
branch
from
8c0370a to
db9e85c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
No description provided.