Skip to content

LCAO refactor Step 4:Eliminate the LCAO_hamilt.cpp file and related class #3920

Description

@mohanchen

Describe the Code Quality Issue

The LCAO_hamilt.cpp was not adapted to current framework of the LCAO line. Most of the functions in the file are now only used for generating H-related matrices with the sparse format. Therefore, a series of spar_.cpp and spar_.h files are desinged instead in the LCAO code directory.

Additional Context

No more.

Task list for Issue attackers (only for developers)

  • Identify the specific code file or section with the code quality issue.
  • Investigate the issue and determine the root cause.
  • Research best practices and potential solutions for the identified issue.
  • Refactor the code to improve code quality, following the suggested solution.
  • Ensure the refactored code adheres to the project's coding standards.
  • Test the refactored code to ensure it functions as expected.
  • Update any relevant documentation, if necessary.
  • Submit a pull request with the refactored code and a description of the changes made.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions