Skip to content

[source_cell] read_atoms_helper.cpp relies on source_estate/read_orb.h #7634

Description

@Critsium-xy

Describe the Code Quality Issue

Calls elecstate::read_orb_file(...) to read orbital files while parsing atoms. Another source_estate circular dependency.

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Identify the specific code file or section with the code quality issue.
  • Investigate the issue and determine the root cause.
  • Research best practices and potential solutions for the identified issue.
  • Refactor the code to improve code quality, following the suggested solution.
  • Ensure the refactored code adheres to the project's coding standards.
  • Test the refactored code to ensure it functions as expected.
  • Update any relevant documentation, if necessary.
  • Submit a pull request with the refactored code and a description of the changes made.

Metadata

Metadata

Assignees

No one assigned

    Labels

    RefactorRefactor ABACUS codesThe Absolute ZeroReduce the "entropy" of the code to 0

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions