Skip to content

Feature: Support GPU diagHsubspace in CG method#1512

Merged
caic99 merged 14 commits into
deepmodeling:developfrom
haozhihan:merge_lapack
Nov 16, 2022
Merged

Feature: Support GPU diagHsubspace in CG method#1512
caic99 merged 14 commits into
deepmodeling:developfrom
haozhihan:merge_lapack

Conversation

@haozhihan

Copy link
Copy Markdown
  1. The diagH_LAPACK interface has been refactored and enabled for multi-device operation
  2. Modified diagH_subspace to support GPU operation

@caic99 caic99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add error checking macro for cuBlas/cuda API calls.

Comment thread source/module_base/lapack_connector.h
Comment thread source/module_base/lapack_connector.h
Comment thread source/module_base/lapack_connector.h
Comment thread source/module_hsolver/test/math_kernel_test.cpp Outdated
@denghuilu denghuilu self-requested a review November 15, 2022 06:12

@denghuilu denghuilu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to support a device version of diagH_subspace_init? It will be helpful for the next development~

Comment thread source/module_hsolver/diago_cg.cpp Outdated
@denghuilu denghuilu self-requested a review November 15, 2022 08:16
Comment thread source/module_hsolver/test/math_kernel_test.cpp Outdated

@caic99 caic99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caic99 caic99 merged commit 25c5b16 into deepmodeling:develop Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants