fix an assert in symmetry#2720
Merged
Merged
Conversation
dyzheng
reviewed
Jul 15, 2023
dyzheng
left a comment
dyzheng
left a comment
Collaborator
There was a problem hiding this comment.
In principle, there should not be any assert in main code.
A assert means this case should not appear with any users inputs.
You can use __DEBUG macrodefinition to braket these asserts, or change them to WARNING_QUIT() if this error can be caused by users inputs.
dyzheng
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2702