Feature: support double type for CG#3153
Merged
Merged
Conversation
maki49
commented
Nov 4, 2023
maki49
commented
Collaborator
- The first step of Iterative eigensolvers for LCAO #3152
- Useful in LR-TDDFT Implementation #2460
Member
|
How about giving a shot at a single precision version also? We're really close with this new PR code, don't you think? |
Collaborator
Author
I think the single precision version could be added easily (just an additional instantiation without changing the definition of kernel templates) by whoever needs it in the future (no need in this PR). |
denghuilu
approved these changes
Nov 6, 2023
denghuilu
left a comment
denghuilu
left a comment
Member
There was a problem hiding this comment.
LGTM，This PR enhances the CG method with the double precision support, also adds the related UTs.
haozhihan
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.