Skip to content

Fix: Abnormal energies in z direction mag for an isotropic magnetic system#3177

Merged
dyzheng merged 2 commits into
deepmodeling:developfrom
hongriTianqi:fixz
Nov 9, 2023
Merged

Fix: Abnormal energies in z direction mag for an isotropic magnetic system#3177
dyzheng merged 2 commits into
deepmodeling:developfrom
hongriTianqi:fixz

Conversation

@hongriTianqi

@hongriTianqi hongriTianqi commented Nov 8, 2023

Copy link
Copy Markdown

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?

Linked Issue

Fix #3170

What's changed?

  • GlobalV::DOMAG_Z will always be false in NC and NSPIN=4 case
  • GlobalV::DOMAG will always be true in NC and NSPIN=4 case

@hongriTianqi hongriTianqi changed the title Fix: Abnormal energies in z direction mag for an isotropic magnetic s… Fix: Abnormal energies in z direction mag for an isotropic magnetic system Nov 8, 2023
@hongriTianqi hongriTianqi requested a review from dyzheng November 8, 2023 10:18

@dyzheng dyzheng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR truns to the original setting: noncolin=1 refer to DOMAG=1 that all magnetization direction will be calculated; noncolin=0 and lspinorb =1 refer to DOMAG_Z=1 that only magnetization along with z-axis will be calculated.

@dyzheng dyzheng merged commit 49c4821 into deepmodeling:develop Nov 9, 2023
@hongriTianqi hongriTianqi deleted the fixz branch May 10, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abnormal energies in z direction for an isotropic magnetic system in non collinear calculation with soc

2 participants