Build: fix torch build on cuda-12#3203
Merged
Merged
Conversation
Member
|
Why can't the test detect this problem? |
njzjz
approved these changes
Nov 14, 2023
dyzheng
approved these changes
Nov 14, 2023
dyzheng
left a comment
Collaborator
There was a problem hiding this comment.
Maybe the test of cuda compilation should cover different version of cuda, thanks for your contribution.
Member
Author
The tested CUDA environment does not contain PyTorch components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
conda-forge/abacus-feedstock#11
What's changed?
Torch will try to detect all applicable architectures for nvcc.
However, for TorchConfig -> Caffe2Config -> FindCUDA (outdated) -> select_compute_arch, it fails to remove unsupported arch for new CUDA toolkits.
This cause error when building with CUDA 12+:
nvcc fatal : Unsupported gpu architecture 'compute_35'This PR will re-use the detected arch at the CUDA component part for Torch.
Any changes of core modules? (ignore if not applicable)