Skip to content

Feature: add coulomb potential calculation#3214

Merged
Qianruipku merged 5 commits into
deepmodeling:developfrom
Qianruipku:hotfix
Nov 16, 2023
Merged

Feature: add coulomb potential calculation#3214
Qianruipku merged 5 commits into
deepmodeling:developfrom
Qianruipku:hotfix

Conversation

@Qianruipku

Copy link
Copy Markdown
Collaborator

It can be used only for tests since it need large Ecut.
Add UTs for it.
fix #3212

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@denghuilu denghuilu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qianruipku Qianruipku merged commit c7235c8 into deepmodeling:develop Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coulomb potential calculation is needed.

2 participants