Skip to content

Refactor: PW_Basis_Big inherits from PW_Basis_Sup#3218

Merged
Qianruipku merged 2 commits into
deepmodeling:developfrom
YuLiu98:basis
Nov 16, 2023
Merged

Refactor: PW_Basis_Big inherits from PW_Basis_Sup#3218
Qianruipku merged 2 commits into
deepmodeling:developfrom
YuLiu98:basis

Conversation

@YuLiu98

@YuLiu98 YuLiu98 commented Nov 16, 2023

Copy link
Copy Markdown
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

What's changed?

  • Class PW_Basis_Big inherits from PW_Basis_Sup for the read and output of cube files.

@YuLiu98 YuLiu98 requested a review from Qianruipku November 16, 2023 08:54
@Qianruipku Qianruipku merged commit 4b4e701 into deepmodeling:develop Nov 16, 2023
@YuLiu98 YuLiu98 deleted the basis branch November 17, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants