Skip to content

Test: change workflows related to intel image to fix the CI errors.#3231

Merged
dyzheng merged 21 commits into
developfrom
container_test
Nov 21, 2023
Merged

Test: change workflows related to intel image to fix the CI errors.#3231
dyzheng merged 21 commits into
developfrom
container_test

Conversation

@dyzheng

@dyzheng dyzheng commented Nov 20, 2023

Copy link
Copy Markdown
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

What's changed?

Disable avx512 and avx2 to make the image in github CI test.

image

@dyzheng dyzheng requested a review from caic99 November 20, 2023 00:46

@caic99 caic99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling AVX instruction sets affects the performance. Given that ELPA does not support cross-compilation and ABACUS chooses kernel on runtime, I would suggest building containers on self-hosted runners, and keep the default instruction sets.

@dyzheng dyzheng requested a review from caic99 November 20, 2023 03:30
@dyzheng dyzheng changed the title Container: disable avx512 and avx2 in Dockerfile.intel Test: change workflows related to intel image to fix the CI errors. Nov 20, 2023

@caic99 caic99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes the workflow of building containers for latest commit.

@caic99

caic99 commented Nov 20, 2023

Copy link
Copy Markdown
Member

@dyzheng The building tests is failing. Don't forget to fix them later.

@dyzheng

dyzheng commented Nov 20, 2023

Copy link
Copy Markdown
Collaborator Author

@dyzheng The building tests is failing. Don't forget to fix them later.

Thanks for your help.

@dyzheng dyzheng merged commit 9af48f8 into develop Nov 21, 2023
@caic99 caic99 deleted the container_test branch November 22, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants