Skip to content

Fix: wrong override in veff_lcao, and some error annotations#3367

Merged
WHUweiqingzhou merged 1 commit into
deepmodeling:developfrom
dyzheng:fix_veff
Dec 22, 2023
Merged

Fix: wrong override in veff_lcao, and some error annotations#3367
WHUweiqingzhou merged 1 commit into
deepmodeling:developfrom
dyzheng:fix_veff

Conversation

@dyzheng

@dyzheng dyzheng commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator

What's changed?

  • Fix the wrong function Veff<OperatorLCAO<TK, TR>>::contributeHK(), the correct function for this derivative class is OperatorLCAO<TK, TR>::contributeHK() after this PR.
  • Fix incorrect annotations for HContainer since last feature changes.

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@dyzheng dyzheng linked an issue Dec 22, 2023 that may be closed by this pull request
14 tasks

@WHUweiqingzhou WHUweiqingzhou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!

@WHUweiqingzhou WHUweiqingzhou merged commit e7c367d into deepmodeling:develop Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New tools in container module HContainer

2 participants