Skip to content

Test: add unit test of DFTUNew and refactor some code#3814

Merged
WHUweiqingzhou merged 6 commits into
deepmodeling:developfrom
dyzheng:ut_dftu
Apr 2, 2024
Merged

Test: add unit test of DFTUNew and refactor some code#3814
WHUweiqingzhou merged 6 commits into
deepmodeling:developfrom
dyzheng:ut_dftu

Conversation

@dyzheng

@dyzheng dyzheng commented Mar 26, 2024

Copy link
Copy Markdown
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #3800

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@WHUweiqingzhou WHUweiqingzhou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. More UnitTests protect new DFTU code.

Comment thread source/module_hamilt_lcao/module_dftu/dftu.h

@WHUweiqingzhou WHUweiqingzhou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I review it again, and all comments have been solved.

@WHUweiqingzhou WHUweiqingzhou merged commit 42a086e into deepmodeling:develop Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code quality should update in class "DFTUNew"

2 participants