Skip to content

Refactor:Remove Ucell::update_pos_taud#5794

Merged
mohanchen merged 10 commits into
deepmodeling:developfrom
A-006:ucell20
Jan 5, 2025
Merged

Refactor:Remove Ucell::update_pos_taud#5794
mohanchen merged 10 commits into
deepmodeling:developfrom
A-006:ucell20

Conversation

@A-006

@A-006 A-006 commented Jan 2, 2025

Copy link
Copy Markdown
Collaborator

Unit Tests and/or Case Tests for my changes

  • The relax_new doesn't run the the update_pos_taud,so in the unit test of the relax_new,it doesn't run the periodic_boundary_adjustment,in order to test the whole function,modify the input paramter to pass the periodic_boundary_adjustment,and modify the result of the func
  • Add unittest for the update_pos_taud in vector3

What's changed?

  • remove the update_pos_taud

@A-006 A-006 marked this pull request as draft January 2, 2025 10:45
@A-006 A-006 marked this pull request as ready for review January 3, 2025 06:19
Comment thread source/module_relax/relax_new/test/relax_test.cpp
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Jan 4, 2025
@mohanchen mohanchen merged commit 4ddec65 into deepmodeling:develop Jan 5, 2025
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
* update the update_pos_taud

* change func with vector3 update_pos_taud

* modify the input format

* add unittest for the update_pos_tau

* update test for relax_new

* add update_vel for ucell

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

The Absolute Zero Reduce the "entropy" of the code to 0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants