Skip to content

Fix: use direct import of full_3x3_to_voigt_6_index - #7042

Merged
mohanchen merged 1 commit into
deepmodeling:developfrom
kirk0830:fix-stress-import
Mar 18, 2026
Merged

Fix: use direct import of full_3x3_to_voigt_6_index#7042
mohanchen merged 1 commit into
deepmodeling:developfrom
kirk0830:fix-stress-import

Conversation

@kirk0830

@kirk0830 kirk0830 commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #7041

Unit Tests and/or Case Tests for my changes

  • not needed

What's changed?

In previous versions, the function to convert the stress tensor full_3x3_to_voigt_6_index is imported from the ase.constraints module, however, it is not the place where the function is implemented, instead, it is an indirect import. In this PR, I change to import it from the ase.stress module

Any changes of core modules? (ignore if not applicable)

  • no

@kirk0830
kirk0830 requested a review from mohanchen March 18, 2026 13:17
@mohanchen mohanchen added Bugs Bugs that only solvable with sufficient knowledge of DFT Interfaces Interfaces with other packages labels Mar 18, 2026

@mohanchen mohanchen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohanchen
mohanchen merged commit 9f550b3 into deepmodeling:develop Mar 18, 2026
15 checks passed
@kirk0830
kirk0830 deleted the fix-stress-import branch March 18, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugs Bugs that only solvable with sufficient knowledge of DFT Interfaces Interfaces with other packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI/CD: workflow crashes with error "cannot import full_3x3_to_voigt_6_index from ase.constraints"

2 participants