Skip to content

[Refactor] Move abfs-vector3_order from source_base to module_ri - #7270

Merged
mohanchen merged 2 commits into
deepmodeling:developfrom
Critsium-xy:source_base_dependency
Apr 21, 2026
Merged

[Refactor] Move abfs-vector3_order from source_base to module_ri#7270
mohanchen merged 2 commits into
deepmodeling:developfrom
Critsium-xy:source_base_dependency

Conversation

@Critsium-xy

Copy link
Copy Markdown
Collaborator

I'm trying to remove dependency of files in source_base. The first one is the abfs-vector3_order. But I find that this file in fact should not be placed in source_base. So I moved its position instead of trying to make it a "basic" module.

@mohanchen mohanchen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Apr 21, 2026
@mohanchen
mohanchen merged commit d756ca6 into deepmodeling:develop Apr 21, 2026
15 checks passed
@Critsium-xy
Critsium-xy deleted the source_base_dependency branch May 6, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants