Skip to content

Remove dependencies in rest files in source_base - #7333

Merged
mohanchen merged 4 commits into
deepmodeling:developfrom
Critsium-xy:remove_parameter_h_global_file
May 12, 2026
Merged

Remove dependencies in rest files in source_base#7333
mohanchen merged 4 commits into
deepmodeling:developfrom
Critsium-xy:remove_parameter_h_global_file

Conversation

@Critsium-xy

@Critsium-xy Critsium-xy commented May 12, 2026

Copy link
Copy Markdown
Collaborator

About this PR:

global_file.cpp used quite a lot of parameters in parameter.h, now a lot of code is modified to remove this dependency.

parallel_global.cpp contains the content of printing the welcome banner, so it needs to use version.h. I think the banner should be moved to main.cpp, so I did this and removed the dependency in this way.

The psi.h dependency in math_kernel is useless now after all the works before. So I directly removed them,

@Critsium-xy
Critsium-xy marked this pull request as ready for review May 12, 2026 08:56

@mohanchen mohanchen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@mohanchen mohanchen added Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0 labels May 12, 2026
@mohanchen
mohanchen merged commit 3ccbad9 into deepmodeling:develop May 12, 2026
15 checks passed
@Critsium-xy
Critsium-xy deleted the remove_parameter_h_global_file branch May 19, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants