Remove redundant CMakeSystem.cmake#7482
Merged
Merged
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR removes a generated CMakeFiles/CMakeSystem.cmake file that appears to have been accidentally committed (it contains machine-specific CMake host/system values), aligning the repository with typical CMake workflows where CMakeFiles/ is build-output and should not live in source control.
Changes:
- Delete
CMakeFiles/CMakeSystem.cmake(CMake-generated system/host configuration output).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@mohanchen Again the testing error...
Maybe it's worth having a look whether #7384 introduced some numeral stability issue, since I think the threshold is loose enough... |
mohanchen
added
the
Compile & CICD & Docs & Dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant
CMakeSystem.cmakeintroduced in #7384 that I believe is by mistake; this is auto-generated in general CMake workflow and there is nothing that can indicate this file is of any special use in the repo.