Try removing GlobalC::exx_info#7575
Conversation
mohanchen
added
Refactor
mohanchen
requested review from
Flying-dragon-boxing
and removed request for
Critsium-xy
I'm not sure if such a code style fix should be included in this PR. Aside from this, this PR is a intermediate state of removing GlobalC::exx_info. Given that this PR doesn't break the tested XC functionals, it might be OK to merge. |
| int func_type = XC_Functional::get_func_type(); | ||
| if (func_type == 0 || func_type == 1) | ||
| { | ||
| ModuleBase::timer::end("Stress","stress_gga"); |
There was a problem hiding this comment.
One note from codex: stress_gga.cpp directly uses ModuleBase::timer::start/end, so source_base/timer.h should remain a direct include. CI did compile successfully, so the issue may currently be masked by transitive includes in that configuration. Still, relying on transitive declarations is fragile, and keeping the direct include makes this translation unit self-contained. I’ll restore it.
There was a problem hiding this comment.
OK, good suggestion
| sigma_gradcorr[m][l] = sigma_gradcorr[l][m]; | ||
| } | ||
| } | ||
| { |
There was a problem hiding this comment.
I'm not sure if this PR should be responsible for replacing tabs with spaces.
There was a problem hiding this comment.
I think it is OK.
2 participants
Try removing GlobalC::exx_info