Skip to content

Refactor: drop source_cell dependency on serialization_cereal (cell->lcao) #7612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohanchen merged 1 commit into from
Jul 8, 2026
Merged

Refactor: drop source_cell dependency on serialization_cereal (cell->lcao) #7612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions source/source_cell/bcast_cell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,30 @@
#include "unitcell.h"
#include "unitcell.h"
#include "source_base/parallel_common.h"
#include "source_io/module_parameter/parameter.h"
#ifdef __EXX
#include "source_lcao/module_ri/serialization_cereal.h"
#endif
#include "source_hamilt/module_xc/exx_info.h" // use GlobalC::exx_info

#include <string>
#include <vector>

namespace unitcell
{
#if defined(__MPI) && defined(__EXX)
// Broadcast a vector<string> from rank 0 to all ranks.
// Replaces the former cereal-based ModuleBase::bcast_data_cereal, which
// was only ever used here to broadcast plain lists of ABFS file names and
// pulled source_cell into a dependency on source_lcao/module_ri.
static void bcast_string_vector(std::vector<std::string>& v)
{
int size = static_cast<int>(v.size());
Parallel_Common::bcast_int(size);
v.resize(size);
for (int i = 0; i < size; ++i)
{
Parallel_Common::bcast_string(v[i]);
}
}
#endif

void bcast_atoms_tau(Atom* atoms,
const int ntype)
{
Expand Down Expand Up @@ -112,15 +129,9 @@ namespace unitcell
}

#ifdef __EXX
ModuleBase::bcast_data_cereal(GlobalC::exx_info.info_ri.files_abfs,
MPI_COMM_WORLD,
0);
ModuleBase::bcast_data_cereal(GlobalC::exx_info.info_opt_abfs.files_abfs,
MPI_COMM_WORLD,
0);
ModuleBase::bcast_data_cereal(GlobalC::exx_info.info_opt_abfs.files_jles,
MPI_COMM_WORLD,
0);
bcast_string_vector(GlobalC::exx_info.info_ri.files_abfs);
bcast_string_vector(GlobalC::exx_info.info_opt_abfs.files_abfs);
bcast_string_vector(GlobalC::exx_info.info_opt_abfs.files_jles);
#endif
return;
#endif
Expand Down
Loading