CMake: Mark ELPA_DIR as deprecated #7630
Open
Growl1234 wants to merge 5 commits into
Open
Conversation
ZhouXY-PKU
reviewed
Jul 13, 2026
ZhouXY-PKU
left a comment
ZhouXY-PKU
left a comment
Collaborator
There was a problem hiding this comment.
Set "deprecated in the future"?
Growl1234
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR,
ELPA_DIRis mark as deprecated and will be removed in the future. With the final removal, CMake will fully leveragepkg-configto find ELPA and get all information of it, includingELPA_VERSION.Users have to ensure
pkg-configis installed and the fileelpa.pcorelpa_openmp.pcis discoverable bypkg-configthroughPKG_CONFIG_PATH(except the case under/usror/usr/include) like:abacus-develop/toolchain/scripts/stage3/install_elpa.sh
Line 259 in 5a8ff7c