Skip to content

Fix missing direct includes in cuSolverMp diagonalizer#7666

Merged
mohanchen merged 1 commit into
deepmodeling:developfrom
Stardust0831:fix/cusolvermp-direct-dependencies
Jul 22, 2026
Merged

Fix missing direct includes in cuSolverMp diagonalizer#7666
mohanchen merged 1 commit into
deepmodeling:developfrom
Stardust0831:fix/cusolvermp-direct-dependencies

Conversation

@Stardust0831

Copy link
Copy Markdown

Summary

  • Include the declarations for BlasConnector::copy() and ModuleBase::TITLE() directly in diago_cusolvermp.cpp.
  • Normalize the file-ending newline.

This keeps the cuSolverMp translation unit self-contained when ENABLE_CUSOLVERMP=ON. Regular CUDA builds do not compile this source unless that option is enabled.

Build evidence

Before this change:

After the equivalent source change:

The overall workflow later reported a separate SDFT numerical test failure; the cuSolverMp-enabled ABACUS build itself completed successfully.

@AsTonyshment AsTonyshment left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Jul 22, 2026
@mohanchen
mohanchen merged commit ff5f570 into deepmodeling:develop Jul 22, 2026
17 checks passed
@Stardust0831
Stardust0831 deleted the fix/cusolvermp-direct-dependencies branch July 22, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants