allow any keywords in strict mode when no allowed keys defined#8
Merged
Conversation
Member
Author
|
@y1xiaoc do you think this is OK? |
Collaborator
|
Should be good. Merged. |
Member
Author
|
Can you publish a new version? |
Collaborator
|
done |
njzjz
added a commit
to deepmodeling/dpgui
that referenced
this pull request
May 9, 2022
wanghan-iapcm
pushed a commit
to deepmodeling/deepmd-kit
that referenced
this pull request
Jan 12, 2023
0.2.8 does not pass the tests. See https://github.com/njzjz/deepmd-kit/actions/runs/3890065119/jobs/6638845358. See also deepmodeling/dargs#8. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
0.2.8 does not pass the tests. See https://github.com/njzjz/deepmd-kit/actions/runs/3890065119/jobs/6638845358. See also deepmodeling/dargs#8. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5.