Skip to content

fix device UT error#1056

Merged
amcadmus merged 2 commits into
deepmodeling:develfrom
denghuilu:fix-ut
Aug 29, 2021
Merged

fix device UT error#1056
amcadmus merged 2 commits into
deepmodeling:develfrom
denghuilu:fix-ut

Conversation

@denghuilu

Copy link
Copy Markdown
Member

No description provided.

@codecov-commenter

codecov-commenter commented Aug 29, 2021

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (a7e4760) to head (6b8910a).
Report is 1492 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1056      +/-   ##
==========================================
+ Coverage   75.10%   75.17%   +0.07%     
==========================================
  Files          87       87              
  Lines        6953     6953              
==========================================
+ Hits         5222     5227       +5     
+ Misses       1731     1726       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galeselee galeselee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on ROCm platform. . The results showed that there are 23 skipped.
'''
Ran 265 tests in 974.050s
OK (skipped=23)
'''
is that normal?

@denghuilu

Copy link
Copy Markdown
Member Author

I tested it on ROCm platform. . The results showed that there are 23 skipped.

'''

Ran 265 tests in 974.050s

OK (skipped=23)

'''

is that normal?

The same as cpu and gpu.

@galeselee

Copy link
Copy Markdown
Contributor

I tested it on ROCm platform. . The results showed that there are 23 skipped.
'''
Ran 265 tests in 974.050s
OK (skipped=23)
'''
is that normal?

The same as cpu and gpu.

But why did the test skip

@amcadmus

Copy link
Copy Markdown
Member

I tested it on ROCm platform. . The results showed that there are 23 skipped.
'''
Ran 265 tests in 974.050s
OK (skipped=23)
'''
is that normal?

The same as cpu and gpu.

But why did the test skip

Skipped when the tf version is not satisfied with the UT. see

@unittest.skipIf(parse_version(tf.__version__) < parse_version("1.15"),

@amcadmus amcadmus merged commit 8dbc211 into deepmodeling:devel Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants