Skip to content

Add image link of ROCm version.#1432

Merged
wanghan-iapcm merged 3 commits into
deepmodeling:develfrom
liangadam:patch-1
Jan 22, 2022
Merged

Add image link of ROCm version.#1432
wanghan-iapcm merged 3 commits into
deepmodeling:develfrom
liangadam:patch-1

Conversation

@liangadam

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread doc/install/easy-install.md Outdated

To pull the ROCm version:
```bash
docker pull deepmodeling/dpmdkit-rocm:dp2.0.4-rocm4.5.2-tf2.6-lmp29Sep2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it dp2.0.4?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I‘m confused, too...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the source code you built from? setuptools-scm will bump a patch version if you do some change to a stable version, but you can use an environment variable to assign the version.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It explains the matter~I have made some adjustments because the gelu gradient definition conflicts with TF 2.6.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also cmakefiles need to be modified on ROCm 3.5 or higher.

@njzjz njzjz changed the base branch from master to devel January 21, 2022 12:56
@njzjz

njzjz commented Jan 21, 2022

Copy link
Copy Markdown
Member

Also, the CI in the master branch is broken, so I changed the base branch to devel.

@wanghan-iapcm wanghan-iapcm merged commit 6238482 into deepmodeling:devel Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants