Skip to content

Merge devel into master#1639

Closed
amcadmus wants to merge 0 commit into
deepmodeling:masterfrom
amcadmus:master
Closed

Merge devel into master#1639
amcadmus wants to merge 0 commit into
deepmodeling:masterfrom
amcadmus:master

Conversation

@amcadmus

Copy link
Copy Markdown
Member

No description provided.

@amcadmus amcadmus requested a review from njzjz April 16, 2022 00:30
@codecov-commenter

codecov-commenter commented Apr 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1639 (bb0d034) into master (3e54fea) will increase coverage by 0.11%.
The diff coverage is 62.17%.

@@            Coverage Diff             @@
##           master    #1639      +/-   ##
==========================================
+ Coverage   76.03%   76.15%   +0.11%     
==========================================
  Files          93       94       +1     
  Lines        7729     7850     +121     
==========================================
+ Hits         5877     5978     +101     
- Misses       1852     1872      +20     
Impacted Files Coverage Δ
deepmd/descriptor/descriptor.py 75.51% <ø> (ø)
deepmd/descriptor/hybrid.py 33.33% <0.00%> (ø)
deepmd/entrypoints/compress.py 73.33% <0.00%> (-1.25%) ⬇️
deepmd/entrypoints/main.py 87.61% <ø> (ø)
deepmd/utils/plugin.py 84.37% <ø> (ø)
deepmd/utils/graph.py 70.47% <15.78%> (-3.09%) ⬇️
deepmd/utils/convert.py 15.46% <18.18%> (-0.33%) ⬇️
deepmd/entrypoints/convert.py 18.18% <25.00%> (-4.05%) ⬇️
deepmd/model/tensor.py 82.45% <27.27%> (-6.01%) ⬇️
deepmd/descriptor/loc_frame.py 96.21% <33.33%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e54fea...bb0d034. Read the comment docs.

@njzjz

njzjz commented Apr 16, 2022

Copy link
Copy Markdown
Member

Shall we merge #1628? That's an important bugfix

@amcadmus

Copy link
Copy Markdown
Member Author

Shall we merge #1628? That's an important bugfix

Sure

@njzjz

njzjz commented Apr 16, 2022

Copy link
Copy Markdown
Member

Note that this branch does not contain #1628...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants