Speed up the download of tensorflow#17
Merged
Merged
Conversation
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 1, 2021
devel update
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 1, 2021
api branch update
This was referenced Mar 21, 2024
wanghan-iapcm
pushed a commit
to wanghan-iapcm/deepmd-kit
that referenced
this pull request
Jun 25, 2026
…onverter to from_dense_quartet build_neighbor_graph now SEARCHES neighbors directly from coordinates and keeps every neighbor within rcut (sel-free), instead of routing through the sel-truncating dense nlist. The legacy quartet adapter is renamed neighbor_graph_from_extended -> from_dense_quartet and documented as the backward-compat converter (inherits sel truncation), separating the 'compute from geometry' dispatcher from the 'adapt an existing list' converters (spec decision deepmodeling#17).
wanghan-iapcm
pushed a commit
to wanghan-iapcm/deepmd-kit
that referenced
this pull request
Jun 27, 2026
The TestCompiledVaryingNatoms dpa1(attn_layer=0) case failed: the uncompiled reference uses the pt_expt carry-all GRAPH forward (default-flip deepmodeling#17) while the compiled forward_lower uses the sel-capped DENSE forward. Those are two different force computations -- even at non-binding sel the forward matches to ~1e-16 but their backward gradients agree only to fp64 accumulation (~1e-12), which the optimizer amplifies into a diverging training trajectory (weight drift ~1e-3 after one step). It is NOT sel-binding and NOT a torch.compile dynamic-shape bug. Pin BOTH sides to the legacy dense env-mat path via force_legacy_descriptor=True (monkeypatch descriptor.uses_graph_lower -> False, killing both the default-flip and the _call_graph_adapter), so this stays a true compile-correctness check on the path it actually compiles. Compiling the GRAPH lower so eager==compiled is tracked for PR-B.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.