bump to C++ 17 for TF 2.10#1898
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #1898 +/- ##
===========================================
- Coverage 77.55% 61.53% -16.02%
===========================================
Files 118 4 -114
Lines 9824 13 -9811
===========================================
- Hits 7619 8 -7611
+ Misses 2205 5 -2200 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Member
Author
|
GCC 5 does not support C++ 17. Shall we remove |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Sep 7, 2022
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
Also, (1) replace `GREATER_EQUAL` by `VERSION_GREATER_EQUAL`. `GREATER_EQUAL` does not work with `2.10`; (2) upgrade manylinux to 2_28 to have a newer compiler that supports C++ 17. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, (1) replace
GREATER_EQUALbyVERSION_GREATER_EQUAL.GREATER_EQUALdoes not work with2.10; (2) upgrade manylinux to 2_28 to have a newer compiler that supports C++ 17.