LAMMPS: Use of “override” instead of “virtual” #1915
Conversation
|
Looks good. |
Codecov Report
@@ Coverage Diff @@
## devel #1915 +/- ##
==========================================
+ Coverage 78.00% 78.02% +0.02%
==========================================
Files 118 114 -4
Lines 9853 9840 -13
==========================================
- Hits 7686 7678 -8
+ Misses 2167 2162 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hi jinzhe, I want commit based on your commit, could you please tell me how to pass this checks. I got the same problems. You can find my code at https://github.com/ZhengdQin/deepmd-kit/tree/ascend . Thanks. |
|
The old checks might be out-of-date. @wanghan-iapcm Is there any reason not to merge with the latest commit? |
|
By the way, @ZhengdQin could you send me your email address? |
zhengdqin@gmail.com is my email. I tred to merge to the latest commit but it leads to some new problems, and my colleagues want to use it as soon as possible, so I decided to merge to ascend branch first and try to merge to the latest commit later. |

fix #1855.