Skip to content

Use GeluCustom as operator name#1918

Merged
wanghan-iapcm merged 3 commits into
deepmodeling:develfrom
denghuilu:gelu-custom
Sep 19, 2022
Merged

Use GeluCustom as operator name#1918
wanghan-iapcm merged 3 commits into
deepmodeling:develfrom
denghuilu:gelu-custom

Conversation

@denghuilu

Copy link
Copy Markdown
Member

This should avoid the conflicts related to the custom Gelu and Tensorflow's Gelu. Also Fix #1913.

@codecov-commenter

codecov-commenter commented Sep 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1918 (f65dcba) into devel (58bed2b) will increase coverage by 0.06%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##            devel    #1918      +/-   ##
==========================================
+ Coverage   78.00%   78.07%   +0.06%     
==========================================
  Files         118      118              
  Lines        9853     9859       +6     
==========================================
+ Hits         7686     7697      +11     
+ Misses       2167     2162       -5     
Impacted Files Coverage Δ
source/op/_gelu.py 68.42% <50.00%> (-0.81%) ⬇️
deepmd/common.py 84.07% <100.00%> (+4.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@njzjz

njzjz commented Sep 16, 2022

Copy link
Copy Markdown
Member

Is it possible to add a test?

@njzjz njzjz linked an issue Sep 16, 2022 that may be closed by this pull request
@denghuilu

Copy link
Copy Markdown
Member Author

Is it possible to add a test?

Agree.

@wanghan-iapcm wanghan-iapcm merged commit 6944885 into deepmodeling:devel Sep 19, 2022
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
This should avoid the conflicts related to the custom `Gelu` and
Tensorflow's `Gelu`. Also Fix deepmodeling#1913.
ZhengdQin pushed a commit to ZhengdQin/deepmd-kit that referenced this pull request Mar 8, 2023
This should avoid the conflicts related to the custom `Gelu` and
Tensorflow's `Gelu`. Also Fix deepmodeling#1913.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gradient registry has no entry for: Gelu

4 participants