Skip to content

handle float point error in sys_probs#1919

Merged
wanghan-iapcm merged 1 commit into
deepmodeling:develfrom
njzjz:sys_probs_floating_point_error
Sep 19, 2022
Merged

handle float point error in sys_probs#1919
wanghan-iapcm merged 1 commit into
deepmodeling:develfrom
njzjz:sys_probs_floating_point_error

Conversation

@njzjz

@njzjz njzjz commented Sep 16, 2022

Copy link
Copy Markdown
Member

Fix #1917.

@njzjz njzjz linked an issue Sep 16, 2022 that may be closed by this pull request
@njzjz njzjz requested a review from wanghan-iapcm September 16, 2022 22:04
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1919 (7221b55) into devel (58bed2b) will decrease coverage by 16.46%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##            devel    #1919       +/-   ##
===========================================
- Coverage   78.00%   61.53%   -16.47%     
===========================================
  Files         118        4      -114     
  Lines        9853       13     -9840     
===========================================
- Hits         7686        8     -7678     
+ Misses       2167        5     -2162     
Impacted Files Coverage Δ
deepmd/utils/data_system.py
deepmd/nvnmd/fit/ener.py
deepmd/model/ener.py
source/op/_soft_min_virial_grad.py
deepmd/descriptor/se_t.py
deepmd/fit/polar.py
source/op/_tanh4_nvnmd_grad.py
deepmd/fit/dipole.py
deepmd/model/tensor.py
deepmd/descriptor/se.py
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit b396ca7 into deepmodeling:devel Sep 19, 2022
@njzjz njzjz deleted the sys_probs_floating_point_error branch September 19, 2022 03:53
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
ZhengdQin pushed a commit to ZhengdQin/deepmd-kit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Sum of sys_probs not equal to 1.0

3 participants